Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DatePickerInput): add helperText support #9200

Merged
merged 3 commits into from
Jul 19, 2021
Merged

feat(DatePickerInput): add helperText support #9200

merged 3 commits into from
Jul 19, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jul 14, 2021 •
edited
Loading

Closes #9199

This PR adds support for helperText in the DatePicker component

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 4335ec3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60f5b0484e78aa000703a782

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4335ec3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60f5b048feb53c000841cf0d

😎 Browse the preview: https://deploy-preview-9200--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4335ec3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60f5b0481e118400076751d3

😎 Browse the preview: https://deploy-preview-9200--carbon-components-react.netlify.app

@aagonzales
Copy link
Member

@emyarod What you have in the PR is correct!

@emyarod emyarod requested a review from aagonzales July 15, 2021 21:33
@emyarod emyarod marked this pull request as ready for review July 15, 2021 21:33
@emyarod emyarod requested review from a team as code owners July 15, 2021 21:33
@emyarod emyarod requested review from joshblack and dakahn July 15, 2021 21:33
tw15egan
tw15egan approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 4b5b5fd into carbon-design-system:main Jul 19, 2021
@emyarod emyarod deleted the 9199-date-picker-helper-text branch July 20, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@joshblack joshblack joshblack approved these changes

@aagonzales aagonzales Awaiting requested review from aagonzales

@dakahn dakahn Awaiting requested review from dakahn

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing helperText feature in DatePicker component
4 participants
@emyarod @aagonzales @joshblack @tw15egan