Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UIShell): add UI shell sass module #9195

Merged
merged 7 commits into from
Jul 20, 2021

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Jul 13, 2021

Closes #9129

Ports the UI Shell to sass module, includes the full theming ability.

Changelog

New

  • UI Shell styles ported over to sass modules, and broken into 5 pieces:
    • content
    • header
    • header-panel
    • side-nav
    • switcher
  • All can be imported by just using @use 'ui-shell. Not sure if there is a desire to only import certain pieces, as most are intertwined.

Changed

  • Combined _vars.scss and _functions.scss

Removed

  • Removed some deprecated code from side-nav.scss
  • Did not port over _navigation-menu.scss ,_product-switcher.scss, _theme.scss as it relates to the deprecated SideNavHeader, SideNavDetails, and SideNavSwitcher, or other deprecated code styles/tokens.

Testing / Reviewing

Compare the stories from the old storybook to the new one. Be aware, the UI Shell is now fully themed, so you may need to switch themes to see similar color variants.

@netlify
Copy link

netlify bot commented Jul 13, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 377c526

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60f6d998668e5000082e0965

@netlify
Copy link

netlify bot commented Jul 13, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 377c526

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60f6d998019e160007584c2a

😎 Browse the preview: https://deploy-preview-9195--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 13, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 377c526

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60f6d998b8cf8000071a434b

😎 Browse the preview: https://deploy-preview-9195--carbon-components-react.netlify.app

@tw15egan tw15egan marked this pull request as ready for review July 14, 2021 18:23
@tw15egan tw15egan requested a review from a team as a code owner July 14, 2021 18:23
@tw15egan tw15egan requested review from joshblack and dakahn July 14, 2021 18:23
@kodiakhq kodiakhq bot merged commit 3ee76bd into carbon-design-system:main Jul 20, 2021
@tw15egan tw15egan deleted the ui-shell-sass-module branch March 3, 2022 16:13
@jnm2377 jnm2377 mentioned this pull request Mar 15, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Shell Sass module refactor
3 participants