-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UIShell): add UI shell sass module #9195
feat(UIShell): add UI shell sass module #9195
Conversation
❌ Deploy Preview for carbon-react-next failed. 🔨 Explore the source changes: 377c526 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60f6d998668e5000082e0965 |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 377c526 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60f6d998019e160007584c2a 😎 Browse the preview: https://deploy-preview-9195--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 377c526 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60f6d998b8cf8000071a434b 😎 Browse the preview: https://deploy-preview-9195--carbon-components-react.netlify.app |
Closes #9129
Ports the UI Shell to sass module, includes the full theming ability.
Changelog
New
content
header
header-panel
side-nav
switcher
@use 'ui-shell
. Not sure if there is a desire to only import certain pieces, as most are intertwined.Changed
_vars.scss
and_functions.scss
Removed
side-nav.scss
_navigation-menu.scss
,_product-switcher.scss
,_theme.scss
as it relates to the deprecatedSideNavHeader, SideNavDetails, and SideNavSwitcher
, or other deprecated code styles/tokens.Testing / Reviewing
Compare the stories from the old storybook to the new one. Be aware, the UI Shell is now fully themed, so you may need to switch themes to see similar color variants.