-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(breadcrumb): account for menu direction in breadcrumb overflow caret #9189
fix(breadcrumb): account for menu direction in breadcrumb overflow caret #9189
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 482916c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60f9a2eefb302a000734f05a 😎 Browse the preview: https://deploy-preview-9189--carbon-react-next.netlify.app |
cc @tay1orjones, it looks like the displayName was supposed to be set as |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 482916c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60f9a2ee112d2d00083eaf7a 😎 Browse the preview: https://deploy-preview-9189--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 482916c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60f9a2eea418630008519692 😎 Browse the preview: https://deploy-preview-9189--carbon-components-react.netlify.app |
cd7a846
to
e8e2016
Compare
e8e2016
to
bbf67be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this is confusing. React docs include this as an explicit example, though the issue from 2018 mentions that the function param must be named.
The DataTable and TableToolbarMenu snapshots include the ForwardRef and FeatureToggle wrapper in the name, ForwardRef(FeatureToggle(OverflowMenu)
, which I think is ultimately okay. I saw the same thing in the devtools in the initial implementation.
But I get what you're saying - the public API snapshot doesn't actually show displayName as a property of the exported object.
bbf67be
to
0f12487
Compare
0f12487
to
a5fc937
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! 🎉 I'm glad that worked out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
Closes #9155
This PR fixes the ComponentToggle (ref #8863) display names to be the original component names (it was not being assigned before) to fix a regression in adding breadcrumb overflow menu caret styles. It also accounts for new overflow menu changes (support for more menu directions ref #7116)
Testing / Reviewing
Confirm the breadcrumb overflow menu caret appears as expected