Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(treeview): use flex properties over explicit dimensions #9141

Merged
merged 2 commits into from
Jul 9, 2021
Merged

refactor(treeview): use flex properties over explicit dimensions #9141

merged 2 commits into from
Jul 9, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jul 7, 2021

ref #8133

This PR replaces explicit minimum dimensions for tree view node icons with a flex rule that avoids size reductions, originally noticed the rem values were not px conversions

Testing / Reviewing

Confirm that the treeview node icons will not change size even when the node labels are extremely long

@emyarod emyarod requested a review from a team as a code owner July 7, 2021 16:45
@emyarod emyarod requested review from sstrubberg and dakahn July 7, 2021 16:45
@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited
Loading

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 9298a7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60e86bfa0e541b000846d909

@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9298a7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e86bfabb808100080ee1c1

😎 Browse the preview: https://deploy-preview-9141--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 9298a7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e86bfa20c4b80008f3b61e

😎 Browse the preview: https://deploy-preview-9141--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit adf9d28 into carbon-design-system:main Jul 9, 2021
@emyarod emyarod deleted the 8133-prevent-treeview-icon-shrink branch July 9, 2021 16:48
@emyarod emyarod mentioned this pull request Jul 12, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

@sstrubberg sstrubberg Awaiting requested review from sstrubberg

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyarod @joshblack @dakahn