Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HeaderMenu): spread extra props into root element #9139

Merged
merged 6 commits into from
Jul 8, 2021
Merged

fix(HeaderMenu): spread extra props into root element #9139

merged 6 commits into from
Jul 8, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jul 7, 2021

Closes #9134

This PR allows for additional props to be spread onto the UI Shell HeaderMenu which should improve support for testing libraries like Cypress which inject data attributes

Testing / Reviewing

Confirm that any extra props placed on the UI Shell HeaderMenu are ultimately rendered in the DOM

@emyarod emyarod requested a review from a team as a code owner July 7, 2021 16:18
@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited
Loading

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 383686a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60e74c6a919ada00080b5079

@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 383686a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e74c6acde7d00007553670

😎 Browse the preview: https://deploy-preview-9139--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 383686a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e74c6a80ba460007e3fbfa

😎 Browse the preview: https://deploy-preview-9139--carbon-components-react.netlify.app

tw15egan
tw15egan approved these changes Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@andreancardona andreancardona enabled auto-merge (squash) July 8, 2021 18:56
@andreancardona andreancardona merged commit 8ab436e into carbon-design-system:main Jul 8, 2021
@emyarod emyarod deleted the 9134-spread-header-menu-props branch July 9, 2021 14:27
@emyarod emyarod mentioned this pull request Jul 12, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React HeaderMenu does not render data-* attributes
3 participants
@emyarod @tw15egan @andreancardona