Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): use non transparent inline select background #9138

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jul 7, 2021

Closes #9112

This PR sets a ui-background color for inline selects so that themed select options on Windows will be visible (Alternatively we can set explicit values on the select options and optgroups but the menus themselves may still be discolored because of how different OS and browser combinations handle menu rendering and CSS custom properties)

Testing / Reviewing

Confirm that the select options and option groups are visible on dark Carbon themes in all browser and OS combinations

@netlify
Copy link

netlify bot commented Jul 7, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 25a2ff5

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60e875db0013d400074e0bea

@netlify
Copy link

netlify bot commented Jul 7, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 25a2ff5

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e875dbb42e73000746c058

😎 Browse the preview: https://deploy-preview-9138--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 7, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 25a2ff5

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e875db64c4540007533879

😎 Browse the preview: https://deploy-preview-9138--carbon-components-react.netlify.app

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@tw15egan tw15egan requested review from a team and kingtraceyj and removed request for a team July 8, 2021 18:05
@sstrubberg sstrubberg enabled auto-merge (squash) July 9, 2021 16:13
@sstrubberg sstrubberg merged commit 129a7a4 into carbon-design-system:main Jul 9, 2021
@emyarod emyarod deleted the 9112-dark-theme-select-backgrounds branch July 9, 2021 16:48
@emyarod emyarod mentioned this pull request Jul 12, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline Select component needs background in Chrome/Windows
5 participants