Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tag): add Tag to @carbon/styles #9131

Merged
merged 14 commits into from
Jul 23, 2021
Merged

feat(Tag): add Tag to @carbon/styles #9131

merged 14 commits into from
Jul 23, 2021

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jul 7, 2021

Adds Tag to @carbon/styles

@dakahn dakahn requested a review from a team as a code owner July 7, 2021 02:07
@dakahn dakahn requested review from tw15egan and andreancardona July 7, 2021 02:07
@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3adcf95

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60fadbe7fae6be00080adeb0

😎 Browse the preview: https://deploy-preview-9131--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 7, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 974274b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e50c7e7876ff0008aba3d5

😎 Browse the preview: https://deploy-preview-9131--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3adcf95

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60fadbe66a259f000709b0aa

😎 Browse the preview: https://deploy-preview-9131--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 7, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 974274b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e50c7e3fd95f0008eca217

😎 Browse the preview: https://deploy-preview-9131--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 3adcf95

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60fadbe66570d30007fea2d5

😎 Browse the preview: https://deploy-preview-9131--carbon-components-react.netlify.app

@tw15egan
Copy link
Collaborator

tw15egan commented Jul 8, 2021

The styles don't seem to be rendering correctly 🤔

Screen Shot 2021-07-08 at 1 29 14 PM

andreancardona
andreancardona previously requested changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also not seeing updated styles :(

@tw15egan tw15egan mentioned this pull request Jul 19, 2021
Merged
4 tasks
@dakahn
Copy link
Contributor Author

dakahn commented Jul 22, 2021

Sorry this was in limbo so long team -- this one was a real doozy

@tw15egan
Copy link
Collaborator

@dakahn just a few comments, but it looks great! 🎉 🎸

andreancardona
andreancardona reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved - pending TJ's comments 🌮

tw15egan
tw15egan approved these changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@dakahn dakahn mentioned this pull request Jul 23, 2021
Closed
62 tasks
@kodiakhq kodiakhq bot merged commit e680d8f into carbon-design-system:main Jul 23, 2021
This was referenced Aug 3, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@joshblack joshblack joshblack approved these changes

@andreancardona andreancardona Awaiting requested review from andreancardona

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dakahn @tw15egan @joshblack @andreancardona