-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(unstable_treeview): sass refactor #9105
feat(unstable_treeview): sass refactor #9105
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: d36649d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60e4dfe0bb353b0007003593 😎 Browse the preview: https://deploy-preview-9105--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 9d0c340 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60df5064945f46000848e626 😎 Browse the preview: https://deploy-preview-9105--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 9d0c340 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60df5064945f46000848e622 😎 Browse the preview: https://deploy-preview-9105--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: d36649d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e4dfe0786a7b000704d8c0 😎 Browse the preview: https://deploy-preview-9105--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: d36649d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e4dfe0c298140007faa7f8 😎 Browse the preview: https://deploy-preview-9105--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🔥
Closes #9094
Treeview
to SASS modulesTesting:
yarn test --watch packages/styles/scss/components/__tests__/treeview-test.js
packages/carbon-react
runyarn storybook
to make sure none of the styles are broken forUnstable_TreeView