Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unstable_treeview): sass refactor #9105

Merged
merged 4 commits into from
Jul 6, 2021
Merged

feat(unstable_treeview): sass refactor #9105

merged 4 commits into from
Jul 6, 2021

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Jul 2, 2021

Closes #9094

  • Refactors Treeview to SASS modules

Testing:

  • run yarn test --watch packages/styles/scss/components/__tests__/treeview-test.js
  • Make sure tests pass
  • cd packages/carbon-react run yarn storybook to make sure none of the styles are broken for Unstable_TreeView

@andreancardona andreancardona requested a review from a team as a code owner July 2, 2021 17:44
@netlify
Copy link

netlify bot commented Jul 2, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: d36649d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60e4dfe0bb353b0007003593

😎 Browse the preview: https://deploy-preview-9105--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 2, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9d0c340

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60df5064945f46000848e626

😎 Browse the preview: https://deploy-preview-9105--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 2, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 9d0c340

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60df5064945f46000848e622

😎 Browse the preview: https://deploy-preview-9105--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 2, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d36649d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e4dfe0786a7b000704d8c0

😎 Browse the preview: https://deploy-preview-9105--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 2, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: d36649d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e4dfe0c298140007faa7f8

😎 Browse the preview: https://deploy-preview-9105--carbon-components-react.netlify.app

@jnm2377 jnm2377 mentioned this pull request Jul 6, 2021
48 tasks
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable_Treeview SASS Refactor
3 participants