Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(tokens): update color tokens pt3 (#8376)" #9067

Conversation

joshblack
Copy link
Contributor

This reverts commit 3804612.

We've run into several challenges with our tokens being used in our components without a feature toggle 😞 This PR is our first attempt at reverting this behavior so that teams can safely update.

Components impacted:

  • Tag
  • Textarea
  • TextInput
  • Tile
  • TimePicker
  • Toggle
  • Tooltip
  • Treeview
  • UI Shell

Changelog

New

Changed

  • Revert token changes

Removed

Testing / Reviewing

Verify components above render as expected in the netlify preview and no new tokens exist in the stylesheets

@joshblack joshblack requested a review from a team as a code owner June 29, 2021 21:24
@joshblack joshblack requested review from emyarod and jnm2377 June 29, 2021 21:24
@netlify
Copy link

netlify bot commented Jun 29, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: d176677

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60de35055021970007e86548

@netlify
Copy link

netlify bot commented Jun 29, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d176677

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60de3505dd295a000788db31

😎 Browse the preview: https://deploy-preview-9067--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 29, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: d176677

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60de3505faad00000825d42b

😎 Browse the preview: https://deploy-preview-9067--carbon-components-react.netlify.app

@jnm2377
Copy link
Contributor

jnm2377 commented Jun 30, 2021

😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants