Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Toggle): remove aria-label, fix aria-labelledby #9039

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jun 25, 2021

Closes #6567

Running some changes in aria to try and get this thing speaking better with Voiceover in Chrome on macOS

This PR is a WIP -- need to hit it with a little testing and make sure this isn't a regression on some browsers/readers.

@dakahn dakahn requested a review from a team as a code owner June 25, 2021 19:31
@dakahn dakahn requested review from emyarod and tw15egan June 25, 2021 19:31
@netlify
Copy link

netlify bot commented Jun 25, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 734e854

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60d65271a88eec00087ccf6c

😎 Browse the preview: https://deploy-preview-9039--carbon-react-next.netlify.app/iframe

@netlify
Copy link

netlify bot commented Jun 25, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 734e854

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d6527132105600070490bd

😎 Browse the preview: https://deploy-preview-9039--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 25, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 734e854

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d65271c8b2470007b8e908

😎 Browse the preview: https://deploy-preview-9039--carbon-components-react.netlify.app/iframe

@emyarod emyarod marked this pull request as draft June 28, 2021 14:35
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converted to draft while this is still WIP

@tw15egan tw15egan removed their request for review August 30, 2021 16:45
@dakahn dakahn closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle and ToggleSmall aria-label is better placed on the checkbox, not the label element
2 participants