-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): add baseline e2e tests and percy snapshots #8958
chore(test): add baseline e2e tests and percy snapshots #8958
Conversation
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 5435207 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d496b487ba6a0008fd21b9 😎 Browse the preview: https://deploy-preview-8958--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 5435207 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d496b425e5cd00076e8d45 😎 Browse the preview: https://deploy-preview-8958--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emyarod could you try going to browserstack.com, signing out, and then sign back in with SSO - then hop over to percy.io and sign in with browserstack? It recently switched over to SSO, so your old/non-ibm creds may not work. |
got it, thanks! |
❌ Deploy Preview for carbon-react-next failed. 🔨 Explore the source changes: 5435207 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60d496b4e30c13000704f30e |
Refs #8911
Adds baseline end to end tests for 5 components:
AspectRatio
,Breadcrumb
,Button
,ButtonSet
,Modal
. These baseline tests include a percy snapshot for each component.Modal
got some special treatment as an example for the future of how to test and snapshot components at the different breakpoint widths. Even with this, the modal tests all together only take .75s to execute!Changelog
New
Testing / Reviewing
If you're interested to see what the tests are doing:
packages/react
yarn cypress open-ct