Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add baseline e2e tests and percy snapshots #8958

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

tay1orjones
Copy link
Member

Refs #8911

Adds baseline end to end tests for 5 components: AspectRatio, Breadcrumb, Button, ButtonSet, Modal. These baseline tests include a percy snapshot for each component.

Modal got some special treatment as an example for the future of how to test and snapshot components at the different breakpoint widths. Even with this, the modal tests all together only take .75s to execute!

Changelog

New

  • test: e2e and percy snapshots

Testing / Reviewing

  • Status checks should pass
  • Percy status check (and UI) should register new snapshots for the 5 components listed in this PR.

If you're interested to see what the tests are doing:

  • pull down this branch
  • cd into packages/react
  • run yarn cypress open-ct
  • this will open the cypress gui in a new instance of chrome where you can select and run tests, and view the UI it's snapshotting and testing against.

@netlify
Copy link

netlify bot commented Jun 18, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 5435207

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d496b487ba6a0008fd21b9

😎 Browse the preview: https://deploy-preview-8958--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 18, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 5435207

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d496b425e5cd00076e8d45

😎 Browse the preview: https://deploy-preview-8958--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

image

I don't have permission to approve the new snapshots on the percy dashboard

@tay1orjones
Copy link
Member Author

@emyarod could you try going to browserstack.com, signing out, and then sign back in with SSO - then hop over to percy.io and sign in with browserstack? It recently switched over to SSO, so your old/non-ibm creds may not work.

@emyarod
Copy link
Member

emyarod commented Jun 21, 2021

got it, thanks!

@netlify
Copy link

netlify bot commented Jun 24, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 5435207

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60d496b4e30c13000704f30e

@kodiakhq kodiakhq bot merged commit 0180478 into carbon-design-system:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants