Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): explicitly set width for expressive theme #8686

Merged
merged 3 commits into from
May 18, 2021
Merged

fix(button): explicitly set width for expressive theme #8686

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59447a4
fix(button): explicitly set width for expressive theme
emyarod May 13, 2021
8bf93ab
Merge branch 'main' into 8685-specify-btn-set-max-width-rules
kodiakhq[bot] May 18, 2021
e38a0cb
Merge branch 'main' into 8685-specify-btn-set-max-width-rules
kodiakhq[bot] May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/components/src/components/button/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,10 @@
height: rem(20px);
}

.#{$prefix}--btn-set .#{$prefix}--btn.#{$prefix}--btn--expressive {
max-width: rem(320px);
}

// Skeleton State
.#{$prefix}--btn.#{$prefix}--skeleton {
@include skeleton;
Expand All @@ -475,6 +479,8 @@

.#{$prefix}--btn-set .#{$prefix}--btn {
width: 100%;
// 196px from design kit
max-width: rem(196px);

&:not(:focus) {
box-shadow: rem(-1px) 0 0 0 $button-separator;
Expand All @@ -485,11 +491,6 @@
}
}

.#{$prefix}--btn-set .#{$prefix}--btn:not(.#{$prefix}--btn--expressive) {
// 196px from design kit
max-width: rem(196px);
}

.#{$prefix}--btn-set .#{$prefix}--btn:focus + .#{$prefix}--btn {
box-shadow: inherit;
}
Expand Down