Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Layout): add container sizing tokens #8671

Merged
merged 18 commits into from
May 24, 2021
Merged

feat(Layout): add container sizing tokens #8671

merged 18 commits into from
May 24, 2021

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented May 12, 2021 •
edited
Loading

closed #8552

Changes

Adds container sizing tokens:
$size-xs,
$size-sm,
$size-md
$size-lg,
$size-xl,
$size-2xl

Testing

  • run yarn build inside @carbon/layout
  • check that /layout/scss/generated/_size.scss was created properly

@dakahn dakahn requested a review from a team as a code owner May 12, 2021 18:37
@dakahn dakahn requested review from tay1orjones and joshblack and removed request for tay1orjones and joshblack May 12, 2021 18:37
@dakahn dakahn marked this pull request as draft May 12, 2021 18:37
@netlify
Copy link

netlify bot commented May 12, 2021 •
edited
Loading

Deploy Preview for carbon-elements ready!

Built with commit 478e673

https://deploy-preview-8671--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented May 12, 2021 •
edited
Loading

Deploy Preview for carbon-components-react ready!

Built with commit 478e673

https://deploy-preview-8671--carbon-components-react.netlify.app

@dakahn dakahn mentioned this pull request May 13, 2021
Closed
94 tasks
@dakahn dakahn changed the title | WIP | feat(Layout): add container sizing tokens feat(Layout): add container sizing tokens May 13, 2021
@dakahn dakahn marked this pull request as ready for review May 13, 2021 20:15
@dakahn dakahn requested review from joshblack, tw15egan, a team and laurenmrice and removed request for a team May 13, 2021 20:22
joshblack
joshblack approved these changes May 17, 2021
View reviewed changes
packages/layout/src/index.js Outdated Show resolved Hide resolved
@tw15egan
Copy link
Collaborator

Getting undefined when running yarn build

Screen Shot 2021-05-17 at 1 57 32 PM

laurenmrice
laurenmrice approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@joshblack
Copy link
Contributor

@dakahn just seems like a quick snapshot update and you're good to go!

@dakahn dakahn requested a review from a team as a code owner May 19, 2021 19:01
@dakahn dakahn requested review from andreancardona and tw15egan May 19, 2021 19:01
tw15egan
tw15egan requested changes May 19, 2021
View reviewed changes
packages/layout/tasks/build.js Outdated Show resolved Hide resolved
@dakahn dakahn requested a review from tw15egan May 19, 2021 21:51
@kodiakhq kodiakhq bot merged commit dc169a9 into carbon-design-system:main May 24, 2021
@jnm2377 jnm2377 mentioned this pull request May 24, 2021
Closed
22 tasks
@aagonzales aagonzales mentioned this pull request May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@tw15egan tw15egan tw15egan approved these changes

@joshblack joshblack joshblack approved these changes

@andreancardona andreancardona Awaiting requested review from andreancardona

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for container tokens
6 participants
@dakahn @tw15egan @joshblack @andreancardona @laurenmrice @sstrubberg