Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ToggleSkeleton): update styles to match design specs #8445

Closed
wants to merge 8 commits into from

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Apr 16, 2021

Closes #6222

Specs:

md-672px-8 column

New

  • added className for deprecated ToggleSmallSkeleton bc it required different styles, however shared all the same classNames

Changed

  • updated styles for ToggleSkeleton

Testing / Reviewing

Review Toggle skeleton story to make sure it matches design specs.

@jnm2377 jnm2377 requested a review from a team as a code owner April 16, 2021 21:42
@netlify
Copy link

netlify bot commented Apr 16, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d302938

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60b532ae54d5a60007f0a7ec

😎 Browse the preview: https://deploy-preview-8445--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 16, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: d302938

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60b532ae69768d0007dda174

😎 Browse the preview: https://deploy-preview-8445--carbon-components-react.netlify.app/iframe

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think the skeleton looks good for the toggle itself.
  • I think if the toggle is paired with label text above it, we will need to have a skeleton for the label text as well. Here are some specs for the label text above the toggle.

md-672px-8 column copy

@andreancardona
Copy link
Contributor

@jnm2377 Let me know when this is ready for review - with the updates. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle and ToggleSmall Skeleton broken
4 participants