Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breakpoint): update in between breakpoint #8346

Merged
merged 2 commits into from
Apr 10, 2021
Merged

fix(breakpoint): update in between breakpoint #8346

merged 2 commits into from
Apr 10, 2021

Conversation

andreancardona
Copy link
Contributor

Closes #8186

@netlify
Copy link

netlify bot commented Apr 9, 2021

Deploy preview for carbon-elements ready!

Built with commit ddf33ea

https://deploy-preview-8346--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 9, 2021

Deploy preview for carbon-components-react ready!

Built with commit ddf33ea

https://deploy-preview-8346--carbon-components-react.netlify.app

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 5355ab6 into carbon-design-system:main Apr 10, 2021
jeffchew added a commit to jeffchew/carbon that referenced this pull request Jul 2, 2021
This is reverting from the PR merge carbon-design-system#8346, which breaks the mixin from
allowing entering any breakpoint names (sm, md, etc).
kodiakhq bot added a commit that referenced this pull request Jul 6, 2021
…et (#9102)

* fix(breakpoint): revert breakpoint-between removal of breakpoints map

This is reverting from the PR merge #8346, which breaks the mixin from
allowing entering any breakpoint names (sm, md, etc).

* fix(breakpoint): fixing calculation to have +/- 0.02 outside of map-get

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

off-by-one error for breakpoint mixin carbon--breakpoint-between
3 participants