Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Button): add danger variant assistive text #8222

Merged
merged 9 commits into from
Apr 1, 2021
Merged

fix(Button): add danger variant assistive text #8222

merged 9 commits into from
Apr 1, 2021

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Mar 30, 2021

Closes #8220

Adds assistiveText for 'danger' button variant

Testing / Reviewing

  • Make sure that danger button doesn't throw any Accessibility Checker errors
  • With NVDA, JAWS, and VoiceOver ensure that "Danger" is read along with the button's label

@dakahn dakahn requested review from joshblack and tw15egan March 30, 2021 03:58
@dakahn dakahn requested a review from a team as a code owner March 30, 2021 03:58
@netlify
Copy link

netlify bot commented Mar 30, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 9a264f3

https://deploy-preview-8222--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 30, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 9a264f3

https://deploy-preview-8222--carbon-components-react.netlify.app

@dakahn dakahn requested review from joshblack and tw15egan March 31, 2021 00:46
tw15egan
tw15egan approved these changes Mar 31, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voiceover correctly alerting danger on danger button variants

LGTM 👍 ✅

@dakahn dakahn requested a review from a team as a code owner March 31, 2021 17:01
@dakahn dakahn requested a review from joshblack March 31, 2021 21:16
@dakahn dakahn mentioned this pull request Mar 31, 2021
Closed
86 tasks
@kodiakhq kodiakhq bot merged commit 10a1ed4 into carbon-design-system:main Apr 1, 2021
@joshblack joshblack mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button doesn't communicate danger state to screen reader users
3 participants
@dakahn @joshblack @tw15egan