Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ListBox): add top positioning to chevron #7990

Merged
merged 4 commits into from
Mar 8, 2021
Merged

fix(ListBox): add top positioning to chevron #7990

merged 4 commits into from
Mar 8, 2021

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Mar 5, 2021

Closes #7989

Fixes an issue with the Dropdown chevron positioning

Changelog

New

  • Added top property

Testing / Reviewing

Ensure Dropdown and all Listbox components render properly

@tw15egan tw15egan requested a review from a team as a code owner March 5, 2021 02:17
@netlify
Copy link

netlify bot commented Mar 5, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 334aad2

https://deploy-preview-7990--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 5, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 334aad2

https://deploy-preview-7990--carbon-components-react.netlify.app

@jnm2377 jnm2377 requested a review from laurenmrice March 5, 2021 22:40
laurenmrice
laurenmrice approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Base automatically changed from master to main March 8, 2021 16:35
@andreancardona andreancardona enabled auto-merge (squash) March 8, 2021 19:11
@andreancardona andreancardona mentioned this pull request Mar 8, 2021
Closed
2 tasks
@andreancardona andreancardona merged commit 460bf18 into carbon-design-system:main Mar 8, 2021
@janhassel
Copy link
Member

@tw15egan hey, quick question: will this fix be released as a 10.30.1 patch?

@emyarod emyarod mentioned this pull request Mar 22, 2021
Closed
2 tasks
emyarod added a commit to emyarod/carbon that referenced this pull request Mar 22, 2021
@emyarod
Revert "fix(ListBox): add top positioning to chevron (carbon-design-s…
56b6757 
…ystem#7990)"

This reverts commit 460bf18.
@emyarod emyarod mentioned this pull request Mar 22, 2021
Merged
kodiakhq bot added a commit that referenced this pull request Mar 23, 2021
@emyarod @kodiakhq
fix(ListBox): correctly position menu chevron (#8155)
0aed1a8 
* Revert "fix(ListBox): add top positioning to chevron (#7990)"

This reverts commit 460bf18.

* fix(dropdown): remove overwriting mixin

* refactor(dropdown): remove redundant rule

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@tw15egan tw15egan deleted the dropdown-fix branch March 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@andreancardona andreancardona Awaiting requested review from andreancardona

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdown chevron rendering incorrectly in latest release
7 participants
@tw15egan @janhassel @tay1orjones @jnm2377 @laurenmrice @andreancardona @joshblack