Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(icons): add removed icons back to update master file #7964

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Mar 3, 2021

Ref #7732

This PR adds the following icons back into the repo

  • mammogram--stacked.svg
  • logo--delicious.svg
  • logo--stumbleupon.svg
  • logo--google.svg

These icons were removed from the repo before the Carbon icons master file (and Sketch plugin) were updated. In order to remove these icons programmatically from the master file, the plugin needs to know of the deprecated icons existence. This PR adds back these removed assets and a future PR will remove them again, along with the icons that are currently marked for deprecation.

Testing / Reviewing

Confirm that the metadata and category information of the four icons above is present

@netlify
Copy link

netlify bot commented Mar 3, 2021

Deploy preview for carbon-elements ready!

Built with commit 8944014

https://deploy-preview-7964--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 3, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 8944014

https://deploy-preview-7964--carbon-components-react.netlify.app

@emyarod emyarod force-pushed the add-removed-icons-back-to-update-master-file branch from 975588f to ce16670 Compare March 3, 2021 21:15
@kodiakhq kodiakhq bot merged commit 9789bd5 into carbon-design-system:master Mar 6, 2021
@emyarod emyarod mentioned this pull request Mar 8, 2021
60 tasks
@emyarod emyarod deleted the add-removed-icons-back-to-update-master-file branch March 9, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants