fix(multiselect): 5880-multiselect-active-descendent #7908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 443707a |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 443707a https://deploy-preview-7908--carbon-components-react.netlify.app |
jnm2377
changed the title
andreancardona
requested review from
tay1orjones
and removed request for
jnm2377
tw15egan
reviewed
Mar 1, 2021
60 tasks
andreancardona
requested review from
jnm2377 and
tw15egan
and removed request for
joshblack and
jnm2377
jnm2377
approved these changes
Mar 6, 2021
tay1orjones
reviewed
Mar 8, 2021
dakahn
suggested changes
Mar 9, 2021
There was a problem hiding this comment.
Testing with NVDA in Firefox and JAWS 2020 in Chrome on Windows 10
- If the input has selected options the ability to clear them with del is not described in either reader when the input receives focus, only the number of selected items are read along with the title/label like "multiselect title, 5, multiselect label menu"
…80-multiselect-active-descendent-violation
tay1orjones
approved these changes
Mar 16, 2021
dakahn
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5880
CHANGED:
onKeyDownevent handler to theclear input buttonTo clear selection, press DeleteTESTING:
Interact with the MultiSelect component with a browser compatible screen reader (i.e. - VoiceOver test on Safari)
Make sure component is fully interactive with keyboard functionalities and descriptions are detailed enough for all users