Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(social): update social share link #7893

Merged
merged 4 commits into from
Feb 25, 2021
Merged

chore(social): update social share link #7893

merged 4 commits into from
Feb 25, 2021

Conversation

tw15egan
Copy link
Collaborator

Updates the image that appears when a link to Storybook is shared

Testing / Reviewing

See if the new image shows up properly

@tw15egan tw15egan requested a review from a team as a code owner February 24, 2021 23:40
@netlify
Copy link

netlify bot commented Feb 24, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 3eb525d

https://deploy-preview-7893--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 25, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 3eb525d

https://deploy-preview-7893--carbon-components-react.netlify.app

@tw15egan tw15egan force-pushed the update-share-image branch 2 times, most recently from ca84565 to 0ca16f0 Compare February 25, 2021 00:10
@joshblack
Copy link
Contributor

@tw15egan what's a good way to test the social link? I tried dropping the link in Slack but it didn't seem to render 🤔

emyarod
emyarod approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

image

do we want to use a different image host/self host these images?

@tw15egan
Copy link
Collaborator Author

@emyarod I tried with a relative link to the assets folder inside storybook and it didn't work properly, open to ideas

@emyarod
Copy link
Member

emyarod commented Feb 25, 2021

not sure where these assets are from but I assumed these assets were already hosted online by Carbon/IBM somewhere. if anything we could also continue hosting on IBM GitHub like the old image

@tw15egan
Copy link
Collaborator Author

tw15egan commented Feb 25, 2021 •
edited
Loading

@emyarod updated, good catch

@joshblack the deploy preview should have the updated image

@kodiakhq kodiakhq bot merged commit 063e46f into carbon-design-system:master Feb 25, 2021
@joshblack joshblack mentioned this pull request Mar 2, 2021
Merged
@dakahn dakahn mentioned this pull request Mar 4, 2021
Merged
@tay1orjones tay1orjones mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tw15egan @joshblack @emyarod