fix(UIShell): fix overlay issue with modal in content #7891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 77f22ae |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 77f22ae https://deploy-preview-7891--carbon-components-react.netlify.app |
|
Omg I just ran into this issue last week, when I was building out something and I thought I was going crazy and doing something wrong with our modal lol awesome fix! 🎉 |
jnm2377
approved these changes
Feb 25, 2021
dakahn
approved these changes
Mar 2, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7885
Fixes an issue caused by
translate3dand displaying a modal inside of a scrollable content areaChangelog
Changed
Removed
transate3dfrombx-contentTesting / Reviewing
Added a
Modalto the bottom of theUIShellcontent area for testing. Can be removed before merging