Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TextInput): match skeleton state to other form elements #7865

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

tw15egan
Copy link
Collaborator

Refs slack convo: https://ibm-studios.slack.com/archives/C2K6RFJ1G/p1613486609314400

the input of the TextInput component was not getting Skeleton styles, which was causing visual issues when used in conjunction with other form elements. This matches the TextInput skeleton styles to Select, NumberInput, etc..

Changelog

New

  • Included Skeleton styles when the skeleton class is added to TextInput

Testing / Reviewing

Ensure TextInputSkeleton looks like other form elements when using the skeleton variant

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tw15egan tw15egan requested a review from a team as a code owner February 22, 2021 19:54
@tw15egan tw15egan requested review from a team and johnbister and removed request for a team February 22, 2021 19:54
@netlify
Copy link

netlify bot commented Feb 22, 2021

Deploy preview for carbon-elements ready!

Built with commit 94d6ac3

https://deploy-preview-7865--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 22, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 94d6ac3

https://deploy-preview-7865--carbon-components-react.netlify.app

@laurenmrice laurenmrice requested review from laurenmrice and removed request for johnbister February 22, 2021 20:46
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tw15egan Looks good!

@kodiakhq kodiakhq bot merged commit 0310add into carbon-design-system:master Feb 25, 2021
@dakahn dakahn mentioned this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants