-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TextInput): match skeleton state to other form elements #7865
fix(TextInput): match skeleton state to other form elements #7865
Conversation
Deploy preview for carbon-elements ready! Built with commit 94d6ac3 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 94d6ac3 https://deploy-preview-7865--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tw15egan Looks good!
Refs slack convo: https://ibm-studios.slack.com/archives/C2K6RFJ1G/p1613486609314400
the
input
of theTextInput
component was not getting Skeleton styles, which was causing visual issues when used in conjunction with other form elements. This matches theTextInput
skeleton styles toSelect
,NumberInput
, etc..Changelog
New
Skeleton
styles when theskeleton
class is added toTextInput
Testing / Reviewing
Ensure
TextInputSkeleton
looks like other form elements when using the skeleton variant