feat(RadioButtonGroup): add new legendText prop, refactor stories #7846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit f9df432 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit f9df432 https://deploy-preview-7846--carbon-components-react.netlify.app |
joshblack
approved these changes
Feb 19, 2021
dakahn
approved these changes
Feb 24, 2021
tay1orjones
approved these changes
Feb 25, 2021
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
tw15egan
force-pushed
the
radiogroup-update
branch
from
33f4542 to
e133b4e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6829
Based on observations by @carmacleod 🥇 , we were utilizing the (hidden)
FormGroupcomponent to render theRadioButtonGrouplegend text. We were also passing alegendprop toRadioButtonGroupthat was doing nothing.This PR contains a few changes, mainly adding the
legendTextprop toRadioButtonGroup. That way we reduce the burden of an end-user supplying afieldset/legendorFormGroupand they can simply supply thelegendTextprop.Changelog
New
RadioButton-story.jsnow contains stories that encapsulateRadioButtonGroupandRadioButton, and has theDefaultandPlaygroundstoriesChanged
divinside ofRadioButtonGroupis now afieldset, and iflegendTextis provided, it will render alegendelement to supply the label (link).RadioButtonGroup.mdxtoRadioButton.mdxRemoved
RadioButtonGroup-story.jsTesting / Reviewing
Ensure this will properly satisfy a11y concerns with this component, and that there are no breaking changes