fix(list-box): update hover active item background color #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit c42fb55 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit c42fb55 https://deploy-preview-7832--carbon-components-react.netlify.app |
aagonzales
requested changes
Feb 17, 2021
There was a problem hiding this comment.
The selected+hover looks correct now but the original problem in the issue is still there. When using the keyboard and arrowing through the selected options there is no visual indicator. It should look the same keyboard arrowing through the items as it does when you hover over them.
emyarod
force-pushed
the
7490-multiseslect-hover-active-colorss
branch
from
2b4ac32 to
3894b69
Compare
aagonzales
approved these changes
Feb 18, 2021
tay1orjones
approved these changes
Feb 23, 2021
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7490
This PR updates the hover state background color for active/selected items in list boxes per new spec guidelines
Testing / Reviewing
Select and hover over a multiselect item in the storybook and confirm the correct color tokens are used