Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add link02 token #7770

Merged
merged 5 commits into from
Feb 10, 2021

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Feb 9, 2021

Closes #7647
Closes #7051
Closes #6845

Add the new link02 token, update Link styles inside DataTable to use it.

Changelog

New

  • add link02 token

Changed

  • links inside datatable to use link02 on hover or row selection

Testing / Reviewing

  • The new token should be emitted on build. I think I added this right for all the themes but please double check me!
  • The "Status" column in the DataTable story is now a Link instead of plain text. These links should use the link02 value on hover and/or when the row is selected. This should meet WCAG 4.5 ratio for color contrast for all themes.

@tay1orjones
Copy link
Member Author

tay1orjones commented Feb 9, 2021

@aagonzales @joshblack There's one outstanding item for this - the v9 theme alias. A value wasn't provided in the original issue. Should we add one or modify the test to just ignore the new link02 token?

// Test to make sure that all tokens defined exist in the theme
test.each(tokenList)('%s should be defined', (token) => {
expect(theme[token]).toBeDefined();
});

@netlify
Copy link

netlify bot commented Feb 9, 2021

Deploy preview for carbon-elements ready!

Built with commit 0f2be85

https://deploy-preview-7770--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 9, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 0f2be85

https://deploy-preview-7770--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

@tay1orjones I think if there is a good fallback value to use that'd be great, even if it's just setting it to the same value as link-01 if that makes sense.

@aagonzales
Copy link
Member

#3d70b2 should work for the v9 theme.

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants