-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): add link02 token #7770
feat(theme): add link02 token #7770
Conversation
@aagonzales @joshblack There's one outstanding item for this - the v9 theme alias. A value wasn't provided in the original issue. Should we add one or modify the test to just ignore the new carbon/packages/themes/src/__tests__/themes-test.js Lines 20 to 23 in f1c92af
|
Deploy preview for carbon-elements ready! Built with commit 0f2be85 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 0f2be85 https://deploy-preview-7770--carbon-components-react.netlify.app |
@tay1orjones I think if there is a good fallback value to use that'd be great, even if it's just setting it to the same value as link-01 if that makes sense. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Closes #7647
Closes #7051
Closes #6845
Add the new
link02
token, updateLink
styles insideDataTable
to use it.Changelog
New
link02
tokenChanged
link02
on hover or row selectionTesting / Reviewing
Link
instead of plain text. These links should use thelink02
value on hover and/or when the row is selected. This should meet WCAG 4.5 ratio for color contrast for all themes.