-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toggle): adjust disabled toggle styles in data table #7753
Merged
kodiakhq
merged 1 commit into
carbon-design-system:master
from
emyarod:7351-disabled-toggle-in-data-table
Feb 11, 2021
Merged
fix(toggle): adjust disabled toggle styles in data table #7753
kodiakhq
merged 1 commit into
carbon-design-system:master
from
emyarod:7351-disabled-toggle-in-data-table
Feb 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for carbon-elements ready! Built with commit 9ab19e7 |
Deploy preview for carbon-components-react ready! Built with commit 9ab19e7 https://deploy-preview-7753--carbon-components-react.netlify.app |
aagonzales
approved these changes
Feb 8, 2021
Looks good! Thanks for making the test story. |
tw15egan
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
dakahn
approved these changes
Feb 11, 2021
emyarod
force-pushed
the
7351-disabled-toggle-in-data-table
branch
2 times, most recently
from
February 11, 2021 16:39
92feb19
to
9c9c164
Compare
emyarod
force-pushed
the
7351-disabled-toggle-in-data-table
branch
from
February 11, 2021 16:39
9c9c164
to
9ab19e7
Compare
This was referenced Feb 16, 2021
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7351
This PR adds one off disabled styles for toggles in data tables. The example story will be removed prior to merging
Testing / Reviewing
Check the Test data table story and confirm the disabled toggle appears correct