fix(FilterableMultiSelect): extend input outline to trigger button area #7722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 1af836a |
|
Deploy preview for carbon-components-react ready! Built with commit 1af836a https://deploy-preview-7722--carbon-components-react.netlify.app |
|
Slight focus issue in Firefox
|
|
this is what it looks like on Firefox 87 for me
|
|
I originally noticed it on the ESR version and I forgot I had 2 versions installed. But after updating Firefox to the latest I'm still seeing it. Is 87 a nightly or something?
|
|
this looks like an existing issue in Firefox version <87, I can open a separate fix for this. it doesn't appear to be a regression from this PR |
|
Sounds good to me 👍 |
|
#7725 will resolve that issue separately, and this PR will extend the focus outline to the trigger button area |
andreancardona
approved these changes
Feb 3, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: ready to merge 🎉
labels
emyarod
force-pushed
the
7535-multiselect-focus-outline
branch
from
415ceda
to
8564046
Compare
emyarod
force-pushed
the
7535-multiselect-focus-outline
branch
from
8564046
to
1af836a
Compare
This was referenced Feb 16, 2021
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7535
related #7615
This PR resolves a visual issue in the filterable multiselect which expands the input focus outline to the multiselect menu trigger button area
Changelog
New
Changed
Testing / Reviewing
Confirm the filterable multiselect styles are now correct