-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sketch): resolve icon sync artwork issues #7711
fix(sketch): resolve icon sync artwork issues #7711
Conversation
Deploy preview for carbon-elements ready! Built with commit bd4c3e9 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit bd4c3e9 https://deploy-preview-7711--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great for both 16,20 library and 24,32 library! 🎉
Closes #5749
Closes #7712
This PR builds off the symbol name changes in #7648 to resolve issues with the icons sync command skewing artwork or not properly replacing outdated artwork
Changelog
Changed
syncSymbol
andsyncIconSymbols
function signatures to use param object instead of a list of params. This helped with linting by triggering warnings with unused params while refactoring. It will also help in case new params need to be added in the future, since the order of the function params will be unimportant within the config object.Removed
syncSymbolLayers
functionmerge
functionTesting / Reviewing
carbon-elements.sketchplugin.zip