Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sketch): resolve icon sync artwork issues #7711

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Feb 1, 2021

Closes #5749
Closes #7712

This PR builds off the symbol name changes in #7648 to resolve issues with the icons sync command skewing artwork or not properly replacing outdated artwork

Changelog

Changed

  • refactor syncSymbol and syncIconSymbols function signatures to use param object instead of a list of params. This helped with linting by triggering warnings with unused params while refactoring. It will also help in case new params need to be added in the future, since the order of the function params will be unimportant within the config object.

Removed

  • syncSymbolLayers function
  • merge function

Testing / Reviewing

  • Confirm that existing artwork is updated to match the artwork from the library
  • Confirm that new symbols are added to the library
  • Confirm that local shared styles are preserved when updating the library

carbon-elements.sketchplugin.zip

@netlify
Copy link

netlify bot commented Feb 1, 2021

Deploy preview for carbon-elements ready!

Built with commit bd4c3e9

https://deploy-preview-7711--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 1, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit bd4c3e9

https://deploy-preview-7711--carbon-components-react.netlify.app

@andreancardona andreancardona mentioned this pull request Feb 2, 2021
60 tasks
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for both 16,20 library and 24,32 library! 🎉

@kodiakhq kodiakhq bot merged commit 3ce64f1 into carbon-design-system:master Feb 3, 2021
@emyarod emyarod deleted the 5749-icons-sync-edit-existing-icons branch February 5, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants