Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Themes): update skeleton-02 value in g100 theme #7699

Merged
merged 4 commits into from
Feb 5, 2021

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Jan 29, 2021

Closes #3335
Closes #7348
Rel #7679

Updates $skeleton-02 value in g100 theme

Changelog

Changed

  • Bumped $skeleton-02 value from Gray80 to Gray70 to improve contrast

Testing / Reviewing

Ensure $skeleton-02 value is correct

@netlify
Copy link

netlify bot commented Jan 29, 2021

Deploy preview for carbon-elements ready!

Built with commit 34e8f33

https://deploy-preview-7699--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 29, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 34e8f33

https://deploy-preview-7699--carbon-components-react.netlify.app

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's better!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kodiakhq kodiakhq bot merged commit b5aa9c3 into carbon-design-system:master Feb 5, 2021
@tw15egan tw15egan deleted the theme-update branch March 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Checkbox component loading skeleton appears to be static [Tokens]: investigate skeleton values
5 participants