Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update addon to match current release #7694

Conversation

lee-chase
Copy link
Member

Relates to #7048

Update to match the current release published from ibm-cloud-cognitive

@andreancardona publish will fail without bumping the version beyond the current 0.3.0 release.

carbon-bot is already an owner so I believe publishing from Carbon should work.

Changelog

M packages/storybook-addon-carbon-theme/README.md
M packages/storybook-addon-carbon-theme/package.json

@lee-chase lee-chase requested a review from a team as a code owner January 29, 2021 10:16
@lee-chase lee-chase requested review from joshblack and dakahn January 29, 2021 10:16
@netlify
Copy link

netlify bot commented Jan 29, 2021

@netlify
Copy link

netlify bot commented Jan 29, 2021

Deploy preview for carbon-elements failed.

Built with commit 2bfbcb6

https://app.netlify.com/sites/carbon-elements/deploys/6013e067c3570a0007867d7c

@joshblack
Copy link
Contributor

@lee-chase I think this PR may be related to the confusion from the PR being merged and revert in #7700 right?

@lee-chase
Copy link
Member Author

@lee-chase I think this PR may be related to the confusion from the PR being merged and revert in #7700 right?

Yes. Didn't want to prevent a publish.

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, hit the wrong button above 🤦‍♂️

@joshblack
Copy link
Contributor

@lee-chase since we reverted the change that added the package, is this PR still relevant?

I think Andrea shared this in the PR itself, but I think our hope will be to use the storybook preset package and included in that should be an add-on that folks can use.

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a comment year since I made the review mistake earlier 🤦‍♂️

@lee-chase lee-chase requested a review from joshblack February 2, 2021 16:38
@andreancardona
Copy link
Contributor

@lee-chase Hi Lee! Sorry for all the confusion. I made a comment here: #7700

@aledavila and I have been working on a storybook preset that can be seen here: #7569

In which case it made sense to revert #7048. Please let me know if you have any questions or concerns!

@joshblack
Copy link
Contributor

Going to go ahead and close this PR out, let me know if you have any questions @lee-chase after @andreancardona 's clarification above 👀

@joshblack joshblack closed this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants