-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update addon to match current release #7694
chore: update addon to match current release #7694
Conversation
Deploy preview for carbon-components-react failed. Built without sensitive environment variables with commit 2bfbcb6 https://app.netlify.com/sites/carbon-components-react/deploys/6013e0674e27200008935da8 |
Deploy preview for carbon-elements failed. Built with commit 2bfbcb6 https://app.netlify.com/sites/carbon-elements/deploys/6013e067c3570a0007867d7c |
@lee-chase I think this PR may be related to the confusion from the PR being merged and revert in #7700 right? |
Yes. Didn't want to prevent a publish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, hit the wrong button above 🤦♂️
@lee-chase since we reverted the change that added the package, is this PR still relevant? I think Andrea shared this in the PR itself, but I think our hope will be to use the storybook preset package and included in that should be an add-on that folks can use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a comment year since I made the review mistake earlier 🤦♂️
@lee-chase Hi Lee! Sorry for all the confusion. I made a comment here: #7700 @aledavila and I have been working on a storybook preset that can be seen here: #7569 In which case it made sense to revert #7048. Please let me know if you have any questions or concerns! |
Going to go ahead and close this PR out, let me know if you have any questions @lee-chase after @andreancardona 's clarification above 👀 |
Relates to #7048
Update to match the current release published from ibm-cloud-cognitive
@andreancardona publish will fail without bumping the version beyond the current 0.3.0 release.
carbon-bot is already an owner so I believe publishing from Carbon should work.
Changelog
M packages/storybook-addon-carbon-theme/README.md
M packages/storybook-addon-carbon-theme/package.json