Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumb): fix hover bug #7667

Merged
merged 1 commit into from
Jan 27, 2021
Merged

fix(breadcrumb): fix hover bug #7667

merged 1 commit into from
Jan 27, 2021

Conversation

aledavila
Copy link
Contributor

@aledavila aledavila commented Jan 27, 2021

Closes #7016

Thanks @tw15egan from his other PR

Changelog

New

  • added hover to visited

Testing / Reviewing

Primary bug was on firefox. make sure to check it works fine on all themes and it doesn't flash. (check issue for visual)

@aledavila aledavila requested a review from a team as a code owner January 27, 2021 18:09
@netlify
Copy link

netlify bot commented Jan 27, 2021

Deploy preview for carbon-elements ready!

Built with commit 0d6f3db

https://deploy-preview-7667--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 27, 2021

Deploy preview for carbon-components-react ready!

Built with commit 0d6f3db

https://deploy-preview-7667--carbon-components-react.netlify.app

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌🏻

@aledavila aledavila merged commit b8bf64a into carbon-design-system:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[breadcrumb] hover state bug
3 participants