Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker): add more locales to valid locales #7666

Merged

Conversation

tw15egan
Copy link
Collaborator

Adds more locales to the list of valid locales from Flatpickr

Changelog

New

  • A few new locales have been added to the locale PropType

Testing / Reviewing

Ensure the new locale values can be used without emitting a warning

@netlify
Copy link

netlify bot commented Jan 27, 2021

Deploy preview for carbon-elements ready!

Built with commit 222cbde

https://deploy-preview-7666--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 27, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 222cbde

https://deploy-preview-7666--carbon-components-react.netlify.app

@tw15egan tw15egan requested a review from a team as a code owner January 27, 2021 20:05
@guigueb
Copy link
Contributor

guigueb commented Jan 28, 2021

Hello there, in our locales we also have kk, nb, pt-br, zh-cn, and zh-tw.
I see zh-tw has been added.
I'm checking if we map zh-cn to zh.
And I'm checking into the others as well, but as they don't show in flatpickr I'm not sure what we'll do if they are languages we still support.

@andreancardona andreancardona merged commit 12451fc into carbon-design-system:master Jan 28, 2021
@tw15egan tw15egan deleted the date-picker-locale branch March 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants