Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): remove extra or unnecessary ARIA and refactor interactive elements #7659

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Jan 26, 2021

Closes #6938

{{short description}}

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@netlify
Copy link

netlify bot commented Jan 26, 2021

Deploy preview for carbon-elements ready!

Built with commit 51c0350

https://deploy-preview-7659--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 26, 2021

Deploy preview for carbon-components-react ready!

Built with commit 51c0350

https://deploy-preview-7659--carbon-components-react.netlify.app

@dakahn
Copy link
Contributor

dakahn commented Feb 3, 2021

related and potentially could close #7331

@joshblack
Copy link
Contributor Author

joshblack commented Feb 10, 2021

Superseded by #7777

@joshblack joshblack closed this Feb 10, 2021
@joshblack joshblack deleted the 6938-update-combobox-aria-roles branch February 10, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Combobox aria roles to match aria 1.2 spec.
3 participants