Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(project): update rollup dependencies #7633

Merged
merged 8 commits into from
Jan 26, 2021
Merged

feat(project): update rollup dependencies #7633

merged 8 commits into from
Jan 26, 2021

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Jan 22, 2021 •
edited
Loading

This PR updates our rollup dependencies and moves away from rollup-plugin-* to official @rollup/plugin-* variants

Changelog

New

Changed

  • Update packages to use new rollup dependencies and @rollup official plugins

Removed

Testing / Reviewing

  • Verify CI passes as expected
  • Verify projects compile their ESM and CommonJS bundles as expected

@netlify
Copy link

netlify bot commented Jan 22, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 3721e18

https://deploy-preview-7633--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 22, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 3721e18

https://deploy-preview-7633--carbon-components-react.netlify.app

@joshblack joshblack marked this pull request as ready for review January 25, 2021 18:09
@joshblack joshblack requested a review from a team as a code owner January 25, 2021 18:09
emyarod
emyarod approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

tw15egan
tw15egan approved these changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected for me 👍 ✅

@kodiakhq kodiakhq bot merged commit 025b20f into carbon-design-system:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@emyarod emyarod emyarod approved these changes

@aledavila aledavila Awaiting requested review from aledavila

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @emyarod @tw15egan