fix(Checkbox): update focus styles #7620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Jan 21, 2021
|
Deploy preview for carbon-elements ready! Built with commit 4eea27e |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 4eea27e https://deploy-preview-7620--carbon-components-react.netlify.app |
dakahn
approved these changes
Jan 22, 2021
emyarod
reviewed
Jan 25, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6480
Closes #6471
No longer uses
box-shadowto render theCheckboxfocus outline. This fixes issues with theCheckboxin HCM as well as overflow issuesHCM
Changelog
Changed
box-shadowtooutlinewhich is supported in HCMRemoved
Testing / Reviewing
View the Checkbox in Windows 10 HCM and view in Edge and FIrefox with
prefers-contrastenabled