fix(TableToolbarSearch): ensure search cannot be expanded when disabled #7612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit c7218a6 |
|
Deploy preview for carbon-components-react ready! Built with commit c7218a6 https://deploy-preview-7612--carbon-components-react.netlify.app |
emyarod
reviewed
Jan 21, 2021
joshblack
approved these changes
Jan 21, 2021
|
@emyarod let me know if there are any other issues with this 👍 |
emyarod
reviewed
Jan 27, 2021
|
@emyarod updated |
emyarod
approved these changes
Jan 29, 2021
tw15egan
force-pushed
the
table-toolbar-search-disabled
branch
from
6d3d26a to
a4c1a74
Compare
tw15egan
force-pushed
the
table-toolbar-search-disabled
branch
from
a4c1a74 to
c7218a6
Compare
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7522
Disabled styles will now prevent the search from expanding if
disabledis passed toTableToolbarSearchChangelog
New
disabledis passed toTableToolbarSearchTableToolbarSearchfrom the tab order if it is disabledTesting / Reviewing
Pass
disabledtoTableToolbarSearchin theDataTable-filtering.jsfile and make sure the search is not able to interact with