Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Notifications): add hcm media query for missing outlines #7601

Merged

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jan 20, 2021

Closes #6872

Changelog

  • added media queries for Windows High Contrast Mode that set an outline width and style

Testing / Reviewing

In Windows High Contrast Mode you the borders for both notifications variants should be clearly visible.

@dakahn dakahn requested a review from a team as a code owner January 20, 2021 01:30
@dakahn dakahn requested review from joshblack and emyarod January 20, 2021 01:30
@netlify
Copy link

netlify bot commented Jan 20, 2021

Deploy preview for carbon-elements ready!

Built with commit 0984fd8

https://deploy-preview-7601--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 20, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 0984fd8

https://deploy-preview-7601--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

the outer outline now appears in high contrast mode. is the correct issue being referenced in the PR description? the ticket and the name of your feature branch reference accordion instead of notifications

@tw15egan
Copy link
Collaborator

I believe this is the correct issue: #7562

@dakahn
Copy link
Contributor Author

dakahn commented Jan 22, 2021

Yeah, that's my bad. Just typed what I was looking at instead of what I should have been referencing 😓

@dakahn dakahn mentioned this pull request Jan 22, 2021
46 tasks
@dakahn dakahn requested a review from emyarod January 22, 2021 02:43
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@andreancardona andreancardona merged commit 6e6e6a5 into carbon-design-system:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion chevron inaccessible in Windows High Contrast Mode
5 participants