feat(Dropdown): add hideTitleText prop #7594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit b7c027d |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit b7c027d https://deploy-preview-7594--carbon-components-react.netlify.app |
emyarod
reviewed
Jan 20, 2021
There was a problem hiding this comment.
would you mind renaming the prop to hideLabel to match the other Carbon components? also it looks like you will need to update snapshots in order to pass CI
edit: yeah it looks like only the listbox components use "title" instead of "label" but this may need to be updated in the future to match the existing components like TextInput, Select, etc.
emyarod
requested review from
a team and
kingtraceyj
and removed request for
a team
…hideLabel-dropdown
…hideLabel-dropdown merge with master please
tw15egan
approved these changes
Jan 21, 2021
tw15egan
added
status: one more review 👀
status: ready for review 👀
and removed
status: failing CI 🙅♂️
labels
emyarod
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Addresses this issue #7571
Changelog
New
hideTitleTextprop for the Dropdown. ThetitleTextwill still exist programatically but hiding it visually lends itself to smoother design (especially with inline Dropdowns). This sort of prop also exists in the Select component.Testing / Reviewing
hideTitleTextprophideTitleTextbeing true. There should not be an error for "The WAI-ARIA property must reference a non-empty unique id of an existing element that is visible" which normally occurs when thetitleTextis missing entirely. However, because we have hidden it visually but not programatically, the error shouldn't appear.