-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ListBox): update listbox components to match spec #7518
fix(ListBox): update listbox components to match spec #7518
Conversation
Deploy preview for carbon-elements ready! Built with commit 3a057c9 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 3a057c9 https://deploy-preview-7518--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropdown
Combobox
-
When the light prop is on, there is a hover color change when you hover on the top field. There should not be a hover color change.
-
The close icon should be
icon-01
-
There needs to be a warning state added in for combobox
Multi-select
Filterable:
-
Needs to have 16px space before the text in the input field.
-
There is a bug when a tag appears in the input field. The tag gets cut off.
-
There is a hover color change when you hover on the top field. There should not be a hover color change.
-
The tag hover is not the right size. Here are the specs for the tag. (This is also wrong for the regular multi-select)
ff8087a
to
5fff142
Compare
@laurenmrice for the last point about tag styles, these are lifted directly from the Filter Tag, so do those need to be adjusted as well? |
@emyarod yes! |
5fff142
to
8ca52ed
Compare
f337fa1
to
e114348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🙌🏻
Ref #7325
This PR updates the Dropdown, Combobox, and MultiSelect components to match the component spec based on the recent component audit notes. The SVG changes will be related to the current ongoing issue with inner fills in icon SVGs (related #3216)
Changelog
New
Changed
Removed
Testing / Reviewing
Confirm the 3 listbox components matches the expected appearance and behavior. Ensure that the new multiselect selection tags are accessible