Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): update getPackages to use cleaned yarn output in berry #7505

Merged

Conversation

joshblack
Copy link
Contributor

It seems like newer versions of yarn strip out extra information. This PR updates our internal getPackages helper to account for this change when generating changelogs.

Changelog

New

Changed

  • Remove logic to trim stdout from yarn lerna command

Removed

Testing / Reviewing

Run the following command and confirm it can generate a changelog:

./packages/cli/bin/carbon-cli.js changelog v10.25.0..HEAD

@joshblack joshblack requested a review from a team as a code owner January 5, 2021 22:16
@joshblack joshblack enabled auto-merge (squash) January 5, 2021 22:16
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noiceee @joshblack

@netlify
Copy link

netlify bot commented Jan 5, 2021

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: cb65bcd

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5ff4e54e6681660007d48115

😎 Browse the preview: https://deploy-preview-7505--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 5, 2021

✔️ Deploy preview for carbon-components-react ready!

🔨 Explore the source changes: cb65bcd

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5ff4e54e80ac3f00070c5b2a

😎 Browse the preview: https://deploy-preview-7505--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 5, 2021

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: e2da819

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5ffdf3e33db49f000720d18f

😎 Browse the preview: https://deploy-preview-7505--carbon-elements.netlify.app

@andreancardona andreancardona self-requested a review January 5, 2021 22:54
@netlify
Copy link

netlify bot commented Jan 5, 2021

✔️ Deploy preview for carbon-components-react ready!

🔨 Explore the source changes: e2da819

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5ffdf3e49ecb810007b0fe24

😎 Browse the preview: https://deploy-preview-7505--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor Author

bump @aledavila let me know if you have any questions!

@joshblack joshblack merged commit df95abf into carbon-design-system:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants