Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CodeSnippet): support disabled single and multiline snippets #7478

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Dec 17, 2020

Closes #7455

This PR adds support for disabled single and multiline code snippets

Changelog

New

  • disabled prop for single and multiline code snippets

Testing / Reviewing

Confirm that the component does not respond and appears correct when disabled

@netlify
Copy link

netlify bot commented Dec 17, 2020

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: c5087c8

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/60071cef4ecf2e00080ad647

😎 Browse the preview: https://deploy-preview-7478--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 17, 2020

✔️ Deploy preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: c5087c8

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/60071cef90116a0007372828

😎 Browse the preview: https://deploy-preview-7478--carbon-components-react.netlify.app

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only bug I see is that the single line code snippet gets a focus when disabled. It should not get focus.
Screen Shot 2020-12-17 at 12 23 29 PM

@emyarod emyarod force-pushed the 7455-disabled-code-snippet branch from 63d24a5 to 548fb2c Compare December 17, 2020 18:35
@emyarod emyarod requested a review from laurenmrice December 17, 2020 18:41
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! 👍🏻

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emyarod looks good 🌞

@andreancardona andreancardona enabled auto-merge (squash) January 15, 2021 23:21
@andreancardona andreancardona merged commit ec9febb into carbon-design-system:master Jan 19, 2021
@emyarod emyarod deleted the 7455-disabled-code-snippet branch January 20, 2021 15:23
@emyarod emyarod mentioned this pull request Jan 22, 2021
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A disabled state/attribute for CodeSnippet
4 participants