refactor(select): remove unused disabled option styles #7477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: a1d9ba7 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5ffe164b85beb60007a507fd 😎 Browse the preview: https://deploy-preview-7477--carbon-elements.netlify.app |
|
✔️ Deploy preview for carbon-components-react ready! 🔨 Explore the source changes: a1d9ba7 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5ffe164b300aba0007cb4e36 😎 Browse the preview: https://deploy-preview-7477--carbon-components-react.netlify.app |
emyarod
force-pushed
the
7475-disabled-select-styles
branch
from
a0fea8f to
b39cd2a
Compare
laurenmrice
approved these changes
Dec 17, 2020
laurenmrice
added
status: one more review 👀
and removed
status: ready for review 👀
status: visual review 🔍
labels
andreancardona
approved these changes
Jan 5, 2021
aledavila
approved these changes
Jan 12, 2021
emyarod
force-pushed
the
7475-disabled-select-styles
branch
from
9f65c91 to
a1d9ba7
Compare
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7475
This PR removes unused styles on the Select component for disabled options. The disabled component already matches the component spec, and opacity rules on disabled
<select>options are not rendered in the browsers we supportTesting / Reviewing
Confirm there are no visual component regressions