Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(dropdown): state disabled background color" #7473

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Revert "fix(dropdown): state disabled background color" #7473

merged 3 commits into from
Jan 5, 2021

Conversation

tw15egan
Copy link
Collaborator

Reverts #7461

@tw15egan tw15egan requested a review from a team as a code owner December 16, 2020 19:28
@tw15egan
Copy link
Collaborator Author

This is causing bugs with hover states on a disabled light dropdown: https://deploy-preview-7461--carbon-components-react.netlify.app/?path=/story/dropdown--playground

@netlify
Copy link

netlify bot commented Dec 16, 2020 •
edited
Loading

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 6a4dd9c

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5ff4df9736545200072a742e

😎 Browse the preview: https://deploy-preview-7473--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 16, 2020 •
edited
Loading

✔️ Deploy preview for carbon-components-react ready!

🔨 Explore the source changes: 6a4dd9c

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5ff4df973c43ca00082d512f

😎 Browse the preview: https://deploy-preview-7473--carbon-components-react.netlify.app

emyarod
emyarod reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any additional context to this change and #7461? before I reviewed the original PR, it was approved and merged but now it's being reverted?

@tw15egan
Copy link
Collaborator Author

tw15egan commented Dec 17, 2020 •
edited
Loading

Hadn't checked that specific variant (light + disabled ) and it came up when reviewing #7466 . I've recommended that all of these PR's should be tied to specific issues before creating PR's

emyarod
emyarod approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see, yeah just wasn't sure what was happening based on PR descriptions and no associated tickets

@joshblack
Merge branch 'master' of github.com:carbon-design-system/carbon into …
e124d48 
…revert-7461-fix-dropdown-state-disabled-background-color
@kodiakhq kodiakhq bot merged commit 978fbdd into master Jan 5, 2021
@kodiakhq kodiakhq bot deleted the revert-7461-fix-dropdown-state-disabled-background-color branch January 5, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tw15egan @joshblack @emyarod