feat(colors): add support for Sass Modules #7395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: 94b373f 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd39f141c1177000870dc67 😎 Browse the preview: https://deploy-preview-7395--carbon-elements.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 94b373f https://deploy-preview-7395--carbon-components-react.netlify.app |
tw15egan
approved these changes
Dec 9, 2020
aledavila
approved these changes
Dec 10, 2020
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Sass Modules with the colors package through
@carbon/colors/scss/module.scssThe generated code for this module looks like:
This PR also adds in an example for bringing in
@carbon/colorsto a project and using it as a Sass Module 👀Changelog
New
module.scssto@carbon/colorsChanged
Removed
Testing / Reviewing
yarn buildin@carbon/colorsmodule.scssfile is built inpackages/colors/scss/module.scsscolors/examples/sass-modulesand then runyarn installandyarn developand verify the color variables work as intended