-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filterable-multiselect): add onMenuChange event #7370
feat(filterable-multiselect): add onMenuChange event #7370
Conversation
Deploy preview for carbon-elements ready! Built with commit 64e64c2 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 64e64c2 https://deploy-preview-7370--carbon-components-react.netlify.app |
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: cdf98eb 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fca5ea4e441a800082acfa2 😎 Browse the preview: https://deploy-preview-7370--carbon-elements.netlify.app |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 85fd9cf https://deploy-preview-7370--carbon-components-react.netlify.app |
✔️ Deploy preview for carbon-components-react ready! 🔨 Explore the source changes: cdf98eb 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5fca5ea46f61cb0008c7906c 😎 Browse the preview: https://deploy-preview-7370--carbon-components-react.netlify.app |
Great catch @tw15egan, thanks! I've fixed most of those issues but I am still having one that I am not sure how to resolve due to my inexperience with downshift. It seems that when you click out of the multiselect, it calls When clicking out of the multi select, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/react/src/components/MultiSelect/FilterableMultiSelect.js
Outdated
Show resolved
Hide resolved
…t.js Co-authored-by: emyarod <emyarod@users.noreply.github.com>
Awesome, thanks for your help! It seems to do the job 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing! 👍 ✅
Closes #6434
This is very similar to #7288, but instead adds the
onMenuChange
event functionality to theFilterableMultiSelect
component.Changelog
New
onMenuChange
event on filterable multiselectChanged
Removed
Testing / Reviewing