feat(date-picker): add warning styles, style audit fixes #7368
Conversation
tw15egan
force-pushed
the
datepicker-audit
branch
from
0035765 to
7672e3d
Compare
|
Deploy preview for carbon-elements ready! Built with commit 0035765 |
|
Deploy preview for carbon-components-react ready! Built with commit 0035765 https://deploy-preview-7368--carbon-components-react.netlify.app |
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: ad7152a 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fca74cadf077c0007f81c04 😎 Browse the preview: https://deploy-preview-7368--carbon-elements.netlify.app |
|
✔️ Deploy preview for carbon-components-react ready! 🔨 Explore the source changes: ad7152a 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5fca74ca961ac3000734ba66 😎 Browse the preview: https://deploy-preview-7368--carbon-components-react.netlify.app |
Closes #7334
Adds in the
warnprop to align with other form components. Also fixes various style bugs, as well as updates the Storybook to view all props on each variation ofDatePickerChangelog
New
warnprop was added toDatePickerinvalidandwarnnow use the proper icons when activebx--date-picker-input__wrapper--invalidandbx--date-picker-input__wrapper--warnadded as wrapper classes to allow better specificity in ourinvalidstyles inform.scssChanged
warningicons that were targeting a[data-icon-path='inner-path']that no longer existssimpleDatePicker no longer has amin-widthbut will have two preset widths to handle the default state and error state.Removed
Testing / Reviewing
Check the playground tab and ensure the 3 variations of
DatePickerlook correct in all states.Keep in mind, a lot of extra styles were added to accommodate
simplevariation with all the wrapper classes.simpleDatePickeralmost seems like it could just be deprecated, as it is essentially just aTextInput.