fix(dataTable): search accessibility issue

[CassidyJensen]

Closes #7358

This PR removes the aria-hidden on the DataTable Toolbar Search Input to remove a11y violations. The search is an input and a focusable element, therefore aria-hidden should never be true.

Changelog

Changed

aria-hidden: {!expanded} [removed]
Aria-hidden was being set by whether the search was expanded. Because it is focusable either way, aria-hidden should always be false. It does not need to be set.

Testing / Reviewing

Inspect the search element on a data table. The input element should have no value for aria-hidden

[netlify]

Deploy preview for carbon-elements ready!

Built with commit bcbc6f8

https://deploy-preview-7359--carbon-elements.netlify.app

[netlify]

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit bcbc6f8

https://deploy-preview-7359--carbon-components-react.netlify.app

[emyarod]

should the attribute just be removed instead of set to false?

[CassidyJensen]

should the attribute just be removed instead of set to false?

A good point, yes it probably should just be removed. I will update it. Thank you!

[emyarod]

thanks for the update, looks good to me

[emyarod]

you most likely will need to update snapshots to pass CI (run yarn test -u)

[CassidyJensen]

you most likely will need to update snapshots to pass CI (run yarn test -u)

@emyarod
I seem to be running into an issue when I run 'yarn test -u' :

Do you have any advice for how to fix it?

[emyarod]

I'm not sure what the test failures are without being able to see the output but I went ahead and updated the snapshots and pushed them up

[CassidyJensen]

Thank you!