fix(FloatingMenu): ignore extra scroll offset in sticky container #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 6a7f35b |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 6a7f35b https://deploy-preview-7323--carbon-components-react.netlify.app |
2 tasks
emyarod
force-pushed
the
7308-floating-menu-placement-in-sticky-container
branch
from
cf6bde5 to
723eb82
Compare
andreancardona
approved these changes
Nov 30, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7308
This PR fixes lazy placement of floating menus within sticky containers
Changelog
New
Testing / Reviewing
Confirm that floating menus are correctly positioned when the trigger element is inside a sticky container and ensure that there are no regressions with floating menu component placement (interactive tooltip, overflow menu)