Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rtl): add RTL plugin to storybook #7297

Closed
wants to merge 1 commit into from

Conversation

tw15egan
Copy link
Collaborator

Rel #7264 #7265 #7266

Adds in an RTL plugin to showcase the components in RTL mode. WIll help with future RTL enhancements and bug fixes

Changelog

New

  • storybook-addon-rtl plugin added to storybook

Testing / Reviewing

Ensure the RTL toggle works properly

Unverified

The email in this signature doesn’t match the committer email.
@tw15egan tw15egan requested a review from a team as a code owner November 16, 2020 19:33
@netlify
Copy link

netlify bot commented Nov 16, 2020

Deploy preview for carbon-elements ready!

Built with commit c450624

https://deploy-preview-7297--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Nov 16, 2020

Deploy preview for carbon-components-react ready!

Built with commit c450624

https://deploy-preview-7297--carbon-components-react.netlify.app

@tw15egan
Copy link
Collaborator Author

tw15egan commented Dec 1, 2020

This plugin doesn't seem like it's going to do what we want it to do. running storybook with the command CARBON_REACT_STORYBOOK_USE_RTL=true yarn storybook properly enables RTL support, so I think we just need more guidance around how to compile styles for RTL

Screen Shot 2020-12-01 at 11 00 16 AM

@tw15egan tw15egan closed this Dec 1, 2020
@tw15egan tw15egan deleted the storybook-rtl branch April 28, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants