Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabs): update scrollable container tabs selectors #7184

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Oct 30, 2020

Closes #7183

related #7109

This PR fixes a regression and updates scrollable container tab selectors to properly apply container tab styles

Testing / Reviewing

Confirm scrollable container tabs match the component spec

@netlify
Copy link

netlify bot commented Oct 30, 2020

Deploy preview for carbon-elements ready!

Built with commit c15233b

https://deploy-preview-7184--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 30, 2020

Deploy preview for carbon-components-react ready!

Built with commit c15233b

https://deploy-preview-7184--carbon-components-react.netlify.app

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@kodiakhq kodiakhq bot merged commit 392b489 into carbon-design-system:master Oct 30, 2020
@emyarod emyarod deleted the 7183-container-tabs-selectors branch October 30, 2020 18:12
@emyarod emyarod mentioned this pull request Nov 12, 2020
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs 'type' prop has no effect
4 participants